Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mobile): use native select for mobile setting #9236

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Dec 21, 2024

CleanShot 2024-12-21 at 12.01.32.gif

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.97%. Comparing base (3a82da0) to head (0b209bf).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9236      +/-   ##
==========================================
+ Coverage   45.32%   51.97%   +6.65%     
==========================================
  Files        2127     2127              
  Lines       97419    97448      +29     
  Branches    16595    16673      +78     
==========================================
+ Hits        44153    50647    +6494     
+ Misses      50937    45413    -5524     
+ Partials     2329     1388     -941     
Flag Coverage Δ
server-test 78.20% <ø> (-0.07%) ⬇️
unittest 31.14% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice CatsJuice force-pushed the catsjuice/feat/mobile-settiing-native-select branch from aad4bb5 to 0b209bf Compare December 22, 2024 06:18
@github-actions github-actions bot added the test Related to test cases label Dec 22, 2024
@CatsJuice CatsJuice marked this pull request as ready for review December 23, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant